Re: [PATCH] staging: media: atomisp: comprehensive coding style cleanup

From: Andy Shevchenko

Date: Mon Mar 09 2026 - 07:20:08 EST


On Mon, Mar 09, 2026 at 12:21:37PM +0200, Sakari Ailus wrote:
> On Sun, Mar 08, 2026 at 11:58:40PM +0200, Laur wrote:
> > @@ -2032,7 +2032,7 @@ static unsigned int long copy_from_compatible(void *to, const void *from,
> > {
> > if (from_user)
> > return copy_from_user(to, (void __user *)from, n);
> > - else
> > +
> > memcpy(to, from, n);
>
> The indentation is wrong here after the change.
>
> > return 0;

This code probably should be changed to use iov_iter facilities.
See the ALSA driver conversions for that, exempli gratia the commit
49aa6ed94c5e ("ALSA: korg1212: Convert to generic PCM copy ops").

--
With Best Regards,
Andy Shevchenko