Re: [PATCH] usb: ucsi: huawei_gaokun: make gaokun_ucsi_ops static

[Heikki Krogerus]

Thu, Mar 05, 2026 at 10:40:36PM +0800, Pengyu Luo kirjoitti:
> The gaokun_ucsi_ops structure is only used within its translation unit
> and is not referenced from any other file. Add the 'static' qualifier
> to avoid unnecessary symbol export.
> 
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603050203.KD4RWA00-lkp@xxxxxxxxx
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> index c5965656b..ca749fde4 100644
> --- a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> +++ b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> @@ -193,7 +193,7 @@ static void gaokun_ucsi_connector_status(struct ucsi_connector *con)
>  	gaokun_set_orientation(con, &uec->ports[idx]);
>  }
>  
> -const struct ucsi_operations gaokun_ucsi_ops = {
> +static const struct ucsi_operations gaokun_ucsi_ops = {
>  	.read_version = gaokun_ucsi_read_version,
>  	.read_cci = gaokun_ucsi_read_cci,
>  	.poll_cci = gaokun_ucsi_read_cci,
> -- 
> 2.53.0

-- 
heikki