Re: [PATCH V3 1/5] dt-bindings: embedded-controller: Add EC bindings for Qualcomm reference devices

[Sibi Sankar]

On 3/9/2026 12:53 PM, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 05:06:42AM +0530, Sibi Sankar wrote:
> > From: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> >
> > Add bindings for the EC firmware running on Hamoa/Purwa and Glymur
> > reference devices, which run on IT8987 and Nuvoton MCUs respectively.
> >
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> > Co-developed-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > ---
> >   .../embedded-controller/qcom,hamoa-ec.yaml    | 52 +++++++++++++++++++
> >   1 file changed, 52 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
> > new file mode 100644
> > index 000000000000..ea093b71d269
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Hamoa Embedded Controller.
> Please implement the feedback from v2.

Ack, sorry missed it.

> > +
> > +maintainers:
> > +  - Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > +
> > +description:
> > +  Qualcomm Snapdragon based Hamoa/Purwa and Glymur reference devices have an
> > +  EC running on IT8987 and Nuvoton MCU chips respectively. The EC handles things
> > +  like fan control, temperature sensors, access to EC internal state changes.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - qcom,glymur-nuvoton-ec
> nuvoton is name of the company, so it's too generic to describe a
> component. It's like calling it "qcom,glymur-qcom-ec". How many EC do
> you have there?

Ack, will get this updated.

> > +          - qcom,hamoa-it8987-ec
> I don't understand this compatible. You already have hamoa.
>
> > +      - const: qcom,hamoa-ec
> So which EC is this?

Will update the compatibles when consensus is achieved
on patch 4 thread.

> Best regards,
> Krzysztof