Re: Missing signoff in the rdma tree
From: Mark Brown
Date: Mon Mar 09 2026 - 07:49:41 EST
On Mon, Mar 09, 2026 at 01:40:20PM +0200, Leon Romanovsky wrote:
> On Mon, Mar 09, 2026 at 11:10:34AM +0000, Mark Brown wrote:
> > eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")
> ➜ kernel git:(wip/leon-for-next) git show eb15cffa15201
> commit eb15cffa15201bd53d1ac296645aa2bc5f726841 (rdma/for-next, rdma/HEAD)
> Author: Sriharsha Basavapatna <sriharsha.basavapatna@xxxxxxxxxxxx>
> Date: Mon Mar 2 16:30:36 2026 +0530
but also, more relevantly:
Commit: Leon Romanovsky <leon@xxxxxxxxxx>
CommitDate: Sun Mar 8 06:20:25 2026 -0400
> RDMA/bnxt_re: Support application specific CQs
>
> <...>
>
> Link: https://patch.msgid.link/r/20260302110036.36387-7-sriharsha.basavapatna@xxxxxxxxxxxx
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@xxxxxxxxxxxx>
> Reviewed-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> <...>
> > are missing a Signed-off-by from their committers
> Signed-off-by exists.
No, I see signoffs from Sriharsha and Jason but not you and it's you who
actually did the commit (see above, git show --pretty=fuller). Did you
by any chance rebase a branch where you'd pulled something from Jason
(or which Jason had pushed to)?
Attachment:
signature.asc
Description: PGP signature