Re: [PATCH 1/4] iio: accel: bmc150: convert to guard(mutex)

From: Waqar Hameed

Date: Mon Mar 09 2026 - 10:39:31 EST


On Mon, Mar 09, 2026 at 19:53 +0530 Rajveer Chaudhari <rajveer.chaudhari.linux@xxxxxxxxx> wrote:

> Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in
> bmc150_accel_buffer_predisable(). This ensures the mutex is
> released on all return paths and allows returning directly
> without a goto label.
>
> Aligned headers in alphabatical order.

Never mix unrelated changes. This should be separate patches. Why? Think
about traceability (bisect etc.).

This comment applies to all other patches in the series as well. I'll
just state it here and wait for V2 before taking a deeper look.

To be honest, I'm not even sure if sorting the headers is a "valid"
patch. It's just cosmetics (and there seems to be no such code style
guidelines)...

[...]