Re: [PATCH v2] dt-bindings: mtd: st,spear600-smi: convert to DT schema

[Miquel Raynal]

Hello Akhila,

On 25/02/2026 at 15:02:50 GMT, Akhila YS <akhilayalmati@xxxxxxxxx> wrote:

> Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI)
> Controller binding to YAML format.
>
> Signed-off-by: Akhila YS <akhilayalmati@xxxxxxxxx>

Gasp :-) Good to see that you actually did fix the issues. Thanks for
doing that. But you've been sending a v2 for a patch that has already
landed in Torvalds' tree. In this case, there are only 2 possibilities:
- sending a revert of the former patch and then this one
- sending fixes like I did
In no case we can just apply this one as-is.

As it's been reviewed already by Rob, I'll take the 3 fixes that I
proposed.

[...]

> +  clock-rate:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Functional clock rate of the SMI controller in Hz.

This clock property (which I did not address in my series) is apparently
not used anywhere upstream. This is a very legacy property, and my
feeling is that it has not been useful for quite some time already (due
to the CCF being able to provide a proper clock tree now). Hence we have
two choices: considering that it does not need to be described at all in
the yaml bindings because it is (very) deprecated property, we might
want to just drop it off. Otherwise you may send a patch specifically
for this addition, however in this case you need to flag it deprecated,
I believe.

Thanks,
Miquèl