Re: [PATCH 4/7] arm64: dts: qcom: Add Arduino Monza (VENTUNOQ) board support

[Krzysztof Kozlowski]

On 09/03/2026 16:24, Srinivas Kandagatla wrote:
> +		};
> +	};
> +
> +
> +	vdc_3v3: regulator-vdc-3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vdc_3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +
> +	vdc_1v8: regulator-vdc-1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vdc_1v8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};
> +
> +	vdc_5v: vdc-5v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vdc_5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		gpio = <&tlmm 49 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		regulator-always-on;
> +		startup-delay-us = <20000>;
> +	};
> +
> +	vreg_nvme: m2-vreg-3p3 {

You have kind of random regulator names. Some are regulators, some are
nothing and some are vregs.

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml

Best regards,
Krzysztof