Re: [PATCH] staging: rtl8723bs: change custom comparing function to memcmp()

[Greg KH]

On Fri, Feb 27, 2026 at 11:06:37PM +0300, Bera Yüzlü wrote:
> eqNByte() function is a redundant reimplementation of memcmp().
> Remove eqNByte() and switch its usages to memcmp().
> No functional change.
> 
> Signed-off-by: Bera Yüzlü <b9788213@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com.c       | 12 ------------
>  .../staging/rtl8723bs/hal/hal_com_phycfg.c    | 19 ++++++++++---------
>  drivers/staging/rtl8723bs/include/hal_com.h   |  2 --
>  3 files changed, 10 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 31b3e880ae6a..a7720f821823 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -750,18 +750,6 @@ void SetHalODMVar(
>  }
>  
>  
> -bool eqNByte(u8 *str1, u8 *str2, u32 num)
> -{
> -	if (num == 0)
> -		return false;
> -	while (num > 0) {
> -		num--;
> -		if (str1[num] != str2[num])
> -			return false;
> -	}
> -	return true;
> -}
> -
>  bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)
>  {
>  	u16 i = 0;
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index dc2da49e6738..b5ba3eba597b 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -8,6 +8,7 @@
>  #include <drv_types.h>
>  #include <hal_data.h>
>  #include <linux/kernel.h>
> +#include <linux/string.h>
>  
>  u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
>  			    enum rate_section RateSection)
> @@ -819,27 +820,27 @@ void PHY_SetTxPowerLimit(
>  
>  	powerLimit = powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimit;
>  
> -	if (eqNByte(Regulation, (u8 *)("FCC"), 3))
> +	if (memcmp(Regulation, "FCC", 3) == 0)
>  		regulation = 0;

This should all be calls to strcmp() instead, right?  These are strings,
please treat them as such.

thanks,

greg k-h