Re: [PATCH v3 24/30] tools: tracing: Append extra cflags

[Ian Rogers]

On Mon, Mar 9, 2026 at 8:44 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Sun, 08 Mar 2026 16:46:29 +0000
> Leo Yan <leo.yan@xxxxxxx> wrote:
>
> > Append EXTRA_CFLAGS to CFLAGS so that additional flags can be applied to
> > the compiler.
> >
> > Signed-off-by: Leo Yan <leo.yan@xxxxxxx>
>
> Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Not a problem with the change but running this patch through an AI
agent brought up:

  Should CFLAGS be initialized with default optimization and warning flags
  (e.g., -g -O2 -Wall)?

  Currently, latency-collector is built without these standard compilation
  flags because they are missing from the Makefile. In other commits in this
  series (like for libbpf and thermal), CFLAGS was explicitly initialized to
 -g -O2 or -g -Wall when EXTRA_CFLAGS is not set.

  Additionally, should EXTRA_WARNINGS (provided by
  tools/scripts/Makefile.include) be appended to CFLAGS here, similar to
  how it is done for other tools?

Thanks,
Ian