Re: [PATCH v6 3/3] arm64: dts: imx95-var-dart: Add support for Variscite Sonata board

[Frank Li]

On Wed, Feb 25, 2026 at 06:03:38PM +0100, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>
>
> Add device tree support for the Variscite Sonata carrier board with
> the DART-MX95 system on module.
>
> The Sonata board includes
> - uSD Card support
> - USB ports and OTG
> - Additional Gigabit Ethernet interface
> - 10Gb Ethernet SFP+ connector
> - Uart interfaces
> - OV5640 Camera support
> - GPIO Expanders
> - RTC module
> - TPM module
> - PCIE support
>
> Link: https://variscite.com/carrier-boards/sonata-board/
> Signed-off-by: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>
> ---
...
> +	};
> +
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> +		led-heartbeat {
> +			label = "Heartbeat";
> +			gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};

gpio-leds should be after gpio-keys.

Can you run https://github.com/lznuaa/dt-format to avoid manual check
such nodes orders.

In past, duplicated nodes was added in sequency update because it is hard
to find duplicate nodes by patch. So we try to enhance node orders for
new dts file to avoid duplicate nodes added in future.

Frank
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
...
> 2.47.3
>