Re: [PATCH v2] iio: dac: mcp47feb02: Fix Vref validation [1-999] case

[Andy Shevchenko]

On Mon, Mar 09, 2026 at 02:12:23PM +0200, Ariana Lazar wrote:
> Store reference voltages in uV instead of mV to avoid invalid error code
> in dev_err_probe() call. Vref variables store the actual value returned by
> devm_regulator_get_enable_read_voltage() function instead of the results of
> dividing it by MILLI. The corner case [1-999] divided by MILLI of the
> voltage reference variable value would become 0 is covered too.

...

> +	vref_uV = 0;
>  	ret = devm_regulator_get_enable_read_voltage(dev, "vref");
>  	if (ret > 0) {
> +		vref_uV = ret;
>  		data->use_vref = true;
>  	} else {
>  		dev_dbg(dev, "using internal band gap as voltage reference.\n");

>  	}

Thanks, but in some cases this will be rewritten. Why not put the assignment
into the 'else' branch?

...


> +		vref1_uV = 0;

Ditto.

>  		ret = devm_regulator_get_enable_read_voltage(dev, "vref1");
>  		if (ret > 0) {
> -			vref1_mV = ret / MILLI;
> +			vref1_uV = ret;
>  			data->use_vref1 = true;
>  		} else {
>  			dev_dbg(dev, "using internal band gap as voltage reference 1.\n");

-- 
With Best Regards,
Andy Shevchenko