Re: [PATCH] media: nxp: imx8-isi: Add virtual channel support

[Frank Li]

From: Frank Li (AI-BOT) <frank.li@xxxxxxx>

> +	/* Platform like i.MX95, ISI support 8 virtual channels */

AI: Typo in commit message/comment: "ISI support" should be "ISI supports"

> -#define CHNL_CTRL_BLANK_PXL(n)					((n) << 16)
> -#define CHNL_CTRL_BLANK_PXL_MASK				GENMASK(23, 16)
> -#define CHNL_CTRL_MIPI_VC_ID(n)					((n) << 6)
> +#define CHNL_CTRL_VC_ID_1(n)					FIELD_PREP(BIT(16), (n))
> +#define CHNL_CTRL_MIPI_VC_ID(n)					FIELD_PREP(GENMASK(7, 6), (n))

AI: Removing CHNL_CTRL_BLANK_PXL and CHNL_CTRL_BLANK_PXL_MASK without explanation.
If these are unused, mention in commit message or confirm they're dead code.

Frank