Re: [PATCH] arm64: dts: qcom: hamoa: Fix OPP tables for all DisplayPort controllers

[Dmitry Baryshkov]

On Mon, Mar 09, 2026 at 04:44:45PM +0200, Abel Vesa wrote:
> According to internal documentation, the corners specific for each rate
> from the DP link clock are:
>  - LOWSVS_D1 -> 19.2 MHz
>  - LOWSVS    -> 270 MHz
>  - SVS       -> 540 MHz (594 MHz in case of DP3)
>  - SVS_L1    -> 594 MHz
>  - NOM       -> 810 MHz
>  - NOM_L1    -> 810 MHz
>  - TURBO     -> 810 MHz
> 
> So fix all tables for each of the four controllers according to the
> documentation.
> 
> The 19.2 @ LOWSVS_D1 isn't needed as the controller will select 162 MHz
> for RBR, which falls under the 270 MHz and it will vote for that LOWSVS
> in that case.

The list of issues isn't limited to Hamoa. As we started to look at it,
could you please also fix Lemans (drop 160, 270, use 594 instead of
540, use single OPP table), Monaco (the same), SAR2130P (leave just 270
and 810), sc7180 (270 at low_svs, drop 160), etc.

> 
> Cc: stable@xxxxxxxxxxxxxxx # v6.9+
> Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/hamoa.dtsi | 49 +++++++++++++++++--------------------
>  1 file changed, 22 insertions(+), 27 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index 4b0784af4bd3..645bc412b0aa 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> @@ -5658,18 +5658,18 @@ mdss_dp0_out: endpoint {
>  				mdss_dp0_opp_table: opp-table {
>  					compatible = "operating-points-v2";
>  
> -					opp-160000000 {
> -						opp-hz = /bits/ 64 <160000000>;
> -						required-opps = <&rpmhpd_opp_low_svs>;
> -					};
> -
>  					opp-270000000 {
>  						opp-hz = /bits/ 64 <270000000>;
> -						required-opps = <&rpmhpd_opp_svs>;
> +						required-opps = <&rpmhpd_opp_low_svs>;
>  					};
>  
>  					opp-540000000 {
>  						opp-hz = /bits/ 64 <540000000>;
> +						required-opps = <&rpmhpd_opp_svs>;
> +					};
> +
> +					opp-594000000 {
> +						opp-hz = /bits/ 64 <594000000>;
>  						required-opps = <&rpmhpd_opp_svs_l1>;
>  					};
>  
> @@ -5747,18 +5747,18 @@ mdss_dp1_out: endpoint {
>  				mdss_dp1_opp_table: opp-table {
>  					compatible = "operating-points-v2";
>  
> -					opp-160000000 {
> -						opp-hz = /bits/ 64 <160000000>;
> -						required-opps = <&rpmhpd_opp_low_svs>;
> -					};
> -
>  					opp-270000000 {
>  						opp-hz = /bits/ 64 <270000000>;
> -						required-opps = <&rpmhpd_opp_svs>;
> +						required-opps = <&rpmhpd_opp_low_svs>;
>  					};
>  
>  					opp-540000000 {
>  						opp-hz = /bits/ 64 <540000000>;
> +						required-opps = <&rpmhpd_opp_svs>;
> +					};
> +
> +					opp-594000000 {
> +						opp-hz = /bits/ 64 <594000000>;
>  						required-opps = <&rpmhpd_opp_svs_l1>;
>  					};
>  
> @@ -5835,18 +5835,18 @@ mdss_dp2_out: endpoint {
>  				mdss_dp2_opp_table: opp-table {
>  					compatible = "operating-points-v2";
>  
> -					opp-160000000 {
> -						opp-hz = /bits/ 64 <160000000>;
> -						required-opps = <&rpmhpd_opp_low_svs>;
> -					};
> -
>  					opp-270000000 {
>  						opp-hz = /bits/ 64 <270000000>;
> -						required-opps = <&rpmhpd_opp_svs>;
> +						required-opps = <&rpmhpd_opp_low_svs>;
>  					};
>  
>  					opp-540000000 {
>  						opp-hz = /bits/ 64 <540000000>;
> +						required-opps = <&rpmhpd_opp_svs>;
> +					};
> +
> +					opp-594000000 {
> +						opp-hz = /bits/ 64 <594000000>;
>  						required-opps = <&rpmhpd_opp_svs_l1>;
>  					};
>  
> @@ -5918,19 +5918,14 @@ mdss_dp3_out: endpoint {
>  				mdss_dp3_opp_table: opp-table {
>  					compatible = "operating-points-v2";
>  
> -					opp-160000000 {
> -						opp-hz = /bits/ 64 <160000000>;
> -						required-opps = <&rpmhpd_opp_low_svs>;
> -					};
> -
>  					opp-270000000 {
>  						opp-hz = /bits/ 64 <270000000>;
> -						required-opps = <&rpmhpd_opp_svs>;
> +						required-opps = <&rpmhpd_opp_low_svs>;
>  					};
>  
> -					opp-540000000 {
> -						opp-hz = /bits/ 64 <540000000>;
> -						required-opps = <&rpmhpd_opp_svs_l1>;
> +					opp-594000000 {
> +						opp-hz = /bits/ 64 <594000000>;
> +						required-opps = <&rpmhpd_opp_svs>;
>  					};
>  
>  					opp-810000000 {
> 
> ---
> base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f
> change-id: 20260309-hamoa-fix-dp3-opp-table-453b8a5e3bc0
> 
> Best regards,
> --  
> Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> 

-- 
With best wishes
Dmitry