Re: [PATCH 6/7] KVM: SVM: Dump FRED context in dump_vmcb()

[Shivansh Dhiman]

On 07-03-2026 07:33, Sean Christopherson wrote:
>> @@ -3461,6 +3482,24 @@ static void dump_vmcb(struct kvm_vcpu *vcpu)
>>  		       "r14:", vcpu->arch.regs[VCPU_REGS_R14],
>>  		       "r15:", vcpu->arch.regs[VCPU_REGS_R15]);
>>  #endif
>> +		pr_err("%-26s %d %-18s %016llx\n",
>> +		       "is_fred_enabled:", is_fred_enabled(vcpu),
>> +		       "guest_evntinjdata:", save->guest_event_inj_data);
>> +		pr_err("%-12s%016llx %-18s%016llx\n",
>> +		       "fred_config:", save->fred_config,
>> +		       "guest_exitintdata:", save->guest_exit_int_data);
>> +		pr_err("%-15s %016llx %-13s %016llx\n",
>> +		       "fred_rsp0:", save->fred_rsp0,
>> +		       "fred_rsp1:", save->fred_rsp1);
>> +		pr_err("%-15s %016llx %-13s %016llx\n",
>> +		       "fred_rsp2:", save->fred_rsp2,
>> +		       "fred_rsp3:", save->fred_rsp3);
>> +		pr_err("%-15s %016llx %-13s %016llx\n",
>> +		       "fred_stklvls:", save->fred_stklvls,
>> +		       "fred_ssp1:", save->fred_ssp1);
>> +		pr_err("%-15s %016llx %-13s %016llx\n",
>> +		       "fred_ssp2:", save->fred_ssp2,
>> +		       "fred_ssp3:", save->fred_ssp3);
> 
> These should all be gated on guest_cpu_cap_has(X86_FEATURE_FRED).  Just because
> KVM can read and print garbage doesn't mean it should.

Will include that in v2. Thanks.

- Shivansh