Re: [PATCH v2 00/11] Add support for the TI BQ25792 battery charger

[Chris Morgan]

On Fri, Mar 06, 2026 at 06:33:00PM +0400, Alexey Charkov wrote:
> This adds support for the TI BQ25792 battery charger, which is similar in
> overall logic to the BQ25703A, but has a different register layout and
> slightly different lower-level programming logic.
> 
> The series is organized as follows:
> - Patch 1 adds the new variant to the existing DT binding, including the
>   changes in electrical characteristics
> - Patches 2-4 are minor cleanups to the existing BQ25703A OTG regulator
>   driver, slimming down the code and making it more reusable for the new
>   BQ25792 variant
> - Patch 5 is a logical fix to the BQ25703A clamping logic for VSYSMIN
>   (this is a standalone fix which can be applied independently and may be
>   backported to stable)
> - Patches 6-8 are slight refactoring of the existing BQ25703A charger
>   driver to make it more reusable for the new BQ25792 variant
> - Patch 9 adds platform data to distinguish between the two variants in
>   the parent MFD driver, and binds it to the new compatible string
> - Patches 10-11 add variant-specific code to support the new BQ25792
>   variant in the regulator part and the charger part respectively,
>   selected by the platform data added in patch 9
> 
> Signed-off-by: Alexey Charkov <alchark@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Fix an error in DT schema (thanks Rob's bot)
> - Ensure the broadest constraints for all variants remain in the common
>   part of the schema, per writing-schema doc (thanks Krzysztof)
> - Link to v1: https://lore.kernel.org/r/20260303-bq25792-v1-0-e6e5e0033458@xxxxxxxxxxx
> 
> ---
> Alexey Charkov (11):
>       dt-bindings: mfd: ti,bq25703a: Expand to include BQ25792
>       regulator: bq257xx: Remove reference to the parent MFD's dev
>       regulator: bq257xx: Drop the regulator_dev from the driver data
>       regulator: bq257xx: Make OTG enable GPIO really optional
>       power: supply: bq257xx: Fix VSYSMIN clamping logic
>       power: supply: bq257xx: Make the default current limit a per-chip attribute
>       power: supply: bq257xx: Consistently use indirect get/set helpers
>       power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states
>       mfd: bq257xx: Add BQ25792 support
>       regulator: bq257xx: Add support for BQ25792
>       power: supply: bq257xx: Add support for BQ25792
> 
>  .../devicetree/bindings/mfd/ti,bq25703a.yaml       |  73 ++-
>  drivers/mfd/bq257xx.c                              |  60 ++-
>  drivers/power/supply/bq257xx_charger.c             | 534 ++++++++++++++++++++-
>  drivers/regulator/bq257xx-regulator.c              | 123 ++++-
>  include/linux/mfd/bq257xx.h                        | 415 ++++++++++++++++
>  5 files changed, 1164 insertions(+), 41 deletions(-)
> ---
> base-commit: d517cb8cea012f43b069617fc8179b45404f8018
> change-id: 20260303-bq25792-0132ac86846d
> 
> Best regards,
> -- 
> Alexey Charkov <alchark@xxxxxxxxxxx>
> 

I did some regression testing with my existing BQ25703 device
(a Gameforce Ace) and did not see any regressions in my testing.

Tested-by: Chris Morgan <macromorgan@xxxxxxxxxxx>