Re: [PATCH bpf-next v7 4/5] selftests/bpf: Add test cases for bpf_list_del/add/is_first/is_last/empty
From: Alexei Starovoitov
Date: Mon Mar 09 2026 - 22:07:44 EST
On Sun, Mar 8, 2026 at 11:44 PM Leon Hwang <leon.hwang@xxxxxxxxx> wrote:
>
> > +long list_add_del_and_check(void *ctx)
> > +{
> > + long err = 0;
> > + struct bpf_rb_node *rb;
> > + struct bpf_list_node *l_node, *l_node_ref;
> > + struct node_data *n_rb, *n_new, *n_new_ref;
> > +
>
> Prefer inverted Christmas tree style.
Just to clarify.
This is not a requirement, but "nice to have" in a new code
if it doesn't interfere with logical declaration of variables.