Re: zram: Optimize LZ4 dictionary compression performance

[Sergey Senozhatsky]

On (26/03/10 15:13), Sergey Senozhatsky wrote:
[..]
> > +		/* rebuild base_cstream when the dictionary changes */
> > +		if (!drv->base_c_valid || drv->dict_gen != params->dict_gen) {
> > +			ret = lz4_build_base_cstream(params);
> > +			if (ret)
> > +				return ret;
> > +		}
> 
> We should not need this, unless I'm missing something.  Params should
                                                                 ^ should not
> change once algorithms are setups and the device is init.