Re: [PATCH v2] serial: 8250: Fix null ptr deref has_acpi_companion

[Jiri Slaby]

The subject is not a proper English though :). Esp. the missing 
preposition. And parens.

What about:
serial: 8250: Fix NULL pointer dereference in has_acpi_companion()
?

On 09. 03. 26, 15:28, Filip Jensen wrote:
...
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -756,6 +756,8 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>   		if (ret)
>   			goto err;
>   	}
> +	if (!uart->port.dev)
> +		return -EINVAL;

Does this even compile?

thanks,
--
js
suse labs