RE: [PATCH v3 1/4] dt-bindings: PCI: pci-imx6: Fix build warning after adding extref clock

[Hongxing Zhu]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 2026年3月10日 16:00
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> bhelgaas@xxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; l.stach@xxxxxxxxxxxxxx;
> lpieralisi@xxxxxxxxxx; kwilczynski@xxxxxxxxxx; mani@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: pci-imx6: Fix build warning after
> adding extref clock
> 
> On Mon, Mar 09, 2026 at 04:44:28PM +0800, Richard Zhu wrote:
> > Fix dtbs_check build warnings by updating the maxItems property for
> > clocks in fsl,imx6q-pcie-common.yaml and completing the clock
> > descriptions in fsl,imx6q-pcie.yaml.
> >
> > The warnings occur because the clock arrays exceed the previously
> > defined maximum length:
> >
> > imx943-evk.dtb: pcie@4c380000 (fsl,imx95-pcie): clock-names: ['pcie',
> > 'pcie_bus', 'pcie_phy', 'pcie_aux', 'ref', 'extref'] is too long
> > imx943-evk.dtb: pcie@4c300000 (fsl,imx95-pcie): clocks: [[5, 74], [5,
> > 41], [5, 40], [5, 75], [46, 0], [47]] is too long
> >
> > Fixes: 1352f58d7c8d ("dt-bindings: PCI: pci-imx6: Add external
> > reference clock input")
> 
> This was three months ago. Can you finally start testing DTS the moment you
> send bindings patches?
> 
> It is not a one time issue - I see multiple buggy patches posted by NXP which
> are never validated with DTS and then months later turns out bindings were
> wrong.
> 
> Many of them are posted and immediately trigger build errors reported by LKP.
> 
> Are you going to finally test patches BEFORE you post them?
Hi Krzysztof:
It's my fault. Would take this lesson, and issue the patches after fully
 tests later.
Sorry about that.

Best Regards
Richard Zhu
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> 
> Best regards,
> Krzysztof