Re: [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy()

[Jani Nikula]

On Tue, 10 Mar 2026, renpanpan <renpanpan@xxxxxxxxxx> wrote:
> Use a safer function strscpy() instead of strcpy() for copying to
> arrays.
> Only idiomatic code replacement, and no functional changes.

This is not true, and the change introduces a bug.

BR,
Jani.

>
> Signed-off-by: renpanpan <renpanpan@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/gvt/opregion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c
> index d6e76ba31d60..e3bb7e0fcd9a 100644
> --- a/drivers/gpu/drm/i915/gvt/opregion.c
> +++ b/drivers/gpu/drm/i915/gvt/opregion.c
> @@ -151,7 +151,7 @@ static void virt_vbt_generation(struct vbt *v)
>  	v->header.vbt_size = sizeof(struct vbt);
>  	v->header.bdb_offset = offsetof(struct vbt, bdb_header);
>  
> -	strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
> +	strscpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
>  	v->bdb_header.version = 186; /* child_dev_size = 33 */
>  	v->bdb_header.header_size = sizeof(v->bdb_header);

-- 
Jani Nikula, Intel