Re: [PATCH v2 1/8] dt-bindings: clock, reset: Add econet EN751221

[Caleb James DeLisle]

On 10/03/2026 09:21, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 01:18:11PM +0000, Caleb James DeLisle wrote:
> > Add clock and reset bindings for EN751221 as well as a "chip-scu" which is
> > an additional regmap that is used by the clock driver as well as others.
> > This split of the SCU across two register areas is the same as the Airoha
> > AN758x family.
> >
> > Signed-off-by: Caleb James DeLisle <cjd@xxxxxxxx>
> > ---
> >   .../bindings/clock/airoha,en7523-scu.yaml     |  7 ++-
> >   .../devicetree/bindings/mfd/syscon.yaml       |  2 +
> >   MAINTAINERS                                   |  2 +
> >   .../dt-bindings/clock/econet,en751221-scu.h   | 13 +++++
> >   .../dt-bindings/reset/econet,en751221-scu.h   | 49 +++++++++++++++++++
> >   5 files changed, 72 insertions(+), 1 deletion(-)
> >   create mode 100644 include/dt-bindings/clock/econet,en751221-scu.h
> >   create mode 100644 include/dt-bindings/reset/econet,en751221-scu.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > index a8471367175b..91abe7716fce 100644
> > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > @@ -32,6 +32,7 @@ properties:
> >         - enum:
> >             - airoha,en7523-scu
> >             - airoha,en7581-scu
> > +          - econet,en751221-scu
> 751 < 752, keep alphanumeric order


"econet," after "airoha," because e > a, of course I can order by number 
if that's really what you want.


> >   
> >     reg:
> >       items:
> > @@ -67,7 +68,10 @@ allOf:
> >     - if:
> >         properties:
> >           compatible:
> > -          const: airoha,en7581-scu
> > +          items:
> <form letter>
> This is a friendly reminder during the review process.


My apologies, I missed this one when I was collecting notes and 
updating. Will fix.

"Drop items, it's just enum"

Thanks,

Caleb


> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
> Best regards,
> Krzysztof