Re: [PATCH] btrfs: reloc: unlink orphan reloc roots before dropping them
From: ZhengYuan Huang
Date: Tue Mar 10 2026 - 04:42:20 EST
On Tue, Mar 10, 2026 at 4:13 PM Qu Wenruo <wqu@xxxxxxxx> wrote:
> > [...]
>
> Put this important info into changelog, and this is not the first time I
> or other reviewing asking you to do it.
Thanks a lot for the detailed review and for being patient with my patch
submissions. I'm still learning the kernel patch submission style,
especially how much detail should go into the changelog above the "---" line
versus what should stay below it.
I think part of my confusion comes from seeing many patches with very concise
changelogs, so I have been trying to keep that part short, but I may
have overdone it and moved too much useful information below the separator.
>From your feedback, my understanding is that the changelog should include
the essential root cause, the fix rationale, and the key crash symptom
(for example
a concise KASAN summary), while the material below "---" should be limited to
supplementary information such as full reproduction details or longer
logs. Is that
the right interpretation?
If there is a patch or changelog example that you think is a good reference
for this style, I would really appreciate it. I'd like to study it carefully
and improve how I write future submissions.
Thanks again for the guidance.
Thanks,
ZhengYuan Huang