Re: [PATCH v2 5/8] dt-bindings: PCI: mediatek: Add support for EcoNet EN7528

[Caleb James DeLisle]

On 10/03/2026 09:25, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 01:18:15PM +0000, Caleb James DeLisle wrote:
> > Introduce EcoNet EN7528 SoC compatible in MediaTek PCIe controller
> > binding.
> >
> > EcoNet PCIe controller has the same configuration model as
> > Mediatek v2 but is initiallized more similarly to an MT7621
> > PCIe.
> >
> > Signed-off-by: Caleb James DeLisle <cjd@xxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/pci/mediatek-pcie.yaml | 1 +
> > 	 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> > index 0b8c78ec4f91..57cbfbff7a31 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> > @@ -14,6 +14,7 @@ properties:
> >       oneOf:
> >         - enum:
> >             - airoha,an7583-pcie
> > +          - econet,en7528-pcie
> Patch is heavily incomplete - why do you have variable number of clocks?
> 1, 2, 3 ... or 6 at the same time?
>
> Look at the rest of this file to understand what you need to write.

Thank you, sorry for missing that, will fix.

Caleb

> Best regards,
> Krzysztof