[PATCH AUTOSEL 6.19-6.12] scsi: devinfo: Add BLIST_SKIP_IO_HINTS for Iomega ZIP

[Sasha Levin]

From: Florian Fuchs <fuchsfl@xxxxxxxxx>

[ Upstream commit 80bf3b28d32b431f84f244a8469488eb6d96afbb ]

The Iomega ZIP 100 (Z100P2) can't process IO Advice Hints Grouping mode
page query. It immediately switches to the status phase 0xb8 after
receiving the subpage code 0x05 of MODE_SENSE_10 command, which fails
imm_out() and turns into DID_ERROR of this command, which leads to unusable
device. This was tested with an Iomega ZIP 100 (Z100P2) connected with a
StarTech PEX1P2 AX99100 PCIe parallel port card.

Prior to this fix, Test Unit Ready fails and the drive can't be used:
        IMM: returned SCSI status b8
        sd 7:0:6:0: [sdh] Test Unit Ready failed: Result: hostbyte=0x01 driverbyte=DRIVER_OK

Signed-off-by: Florian Fuchs <fuchsfl@xxxxxxxxx>
Link: https://patch.msgid.link/20260227181823.892932-1-fuchsfl@xxxxxxxxx
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---

LLM Generated explanations, may be completely bogus:

The IO Advice Hints feature (the source of the bug) was only introduced
in v6.10, and `BLIST_SKIP_IO_HINTS` was also only in v6.10+. The older
stable trees (6.6.y, 6.1.y, 5.15.y) don't have this code path, so they
wouldn't need this fix.

For stable trees that DO have this code (6.10.y, 6.11.y, 6.12.y, etc.),
this is a straightforward one-line quirk addition.

### Analysis Summary

**What the commit fixes:** The Iomega ZIP 100 drive becomes completely
unusable because the IO Advice Hints mode page query causes the device
to error out. The commit message includes specific error output showing
the device fails "Test Unit Ready" with a SCSI status of 0xb8.

**Type of change:** Hardware quirk addition — adding one flag
(`BLIST_SKIP_IO_HINTS`) to an existing device entry in the SCSI device
info table. This is a textbook example of a device-specific workaround.

**Scope and risk:**
- One-line change: adds `| BLIST_SKIP_IO_HINTS` to an existing entry
- Zero risk to other devices — only affects IOMEGA ZIP drives
- The `BLIST_SKIP_IO_HINTS` flag is already well-established and used by
  USB storage devices
- The existing IOMEGA ZIP entry already existed; only the flag set is
  expanded

**User impact:** Without this fix, the Iomega ZIP 100 drive is
completely unusable on kernels v6.10+. The device was tested and
confirmed to work with the fix.

**Dependencies:** Requires `BLIST_SKIP_IO_HINTS` flag definition (commit
`633aeefafc9c2`, present since v6.10). This is already in all stable
trees that have the IO hints feature.

**Stable criteria met:**
1. Obviously correct — adds a quirk flag to skip a mode page query the
   device can't handle
2. Fixes a real bug — device is completely unusable without it
3. Small and contained — single flag addition to one line
4. No new features — uses existing quirk infrastructure

### Verification

- Verified `BLIST_SKIP_IO_HINTS` was introduced in commit
  `633aeefafc9c2` (v6.10) via `git log` and `git tag --contains`
- Verified the Fixes: target `4f53138fffc2` (IO hints feature) was
  introduced in v6.10 via `git tag --contains`
- Verified older stable trees (6.6.y, 6.1.y, 5.15.y) do NOT contain
  either the IO hints feature or the BLIST_SKIP_IO_HINTS flag — so they
  are unaffected
- Verified via grep that `BLIST_SKIP_IO_HINTS` is already used in USB
  storage drivers (`uas.c`, `scsiglue.c`) and checked in `sd.c:3275`
- Verified the change is a single flag addition to an existing device
  entry in `scsi_devinfo.c`
- The IOMEGA ZIP entry already existed in the table (just missing the
  new flag)

**YES**

 drivers/scsi/scsi_devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 78346b2b69c91..c51146882a1fa 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -190,7 +190,7 @@ static struct {
 	{"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
 	{"IBM", "2105", NULL, BLIST_RETRY_HWERROR},
 	{"iomega", "jaz 1GB", "J.86", BLIST_NOTQ | BLIST_NOLUN},
-	{"IOMEGA", "ZIP", NULL, BLIST_NOTQ | BLIST_NOLUN},
+	{"IOMEGA", "ZIP", NULL, BLIST_NOTQ | BLIST_NOLUN | BLIST_SKIP_IO_HINTS},
 	{"IOMEGA", "Io20S         *F", NULL, BLIST_KEY},
 	{"INSITE", "Floptical   F*8I", NULL, BLIST_KEY},
 	{"INSITE", "I325VM", NULL, BLIST_KEY},
-- 
2.51.0