[PATCH AUTOSEL 6.19-6.18] platform/x86: oxpec: Add support for OneXPlayer X1 Air
From: Sasha Levin
Date: Tue Mar 10 2026 - 05:08:54 EST
From: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
[ Upstream commit 2a3b4a8c10a64a62c4243007139d253dc1324dfd ]
X1 Air is an X1 variant with a newer Intel chipset. It uses the same
registers as the X1. Add a quirk for it to the oxpec driver.
Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
Link: https://patch.msgid.link/20260223183004.2696892-4-lkml@xxxxxxxxxxx
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
LLM Generated explanations, may be completely bogus:
The `oxp_x1` board type is used extensively in the driver. The key
concern for backporting is:
1. The driver was renamed from `drivers/hwmon/oxp-sensors.c` to
`drivers/platform/x86/oxpec.c` in April 2025 - stable trees would
need the patch applied to the old file path
2. The `oxp_x1` enum value and associated X1 DMI entries may have been
added after the stable branch points
This is a **new device ID addition** to an existing driver - a classic
exception to stable rules. The change is trivially small (7 lines), zero
risk to existing users, and enables the oxpec driver on a real shipping
hardware device.
### Verification
- `git log` confirmed oxpec.c was renamed from `drivers/hwmon/oxp-
sensors.c` in commit `3012bb39001c4` (April 2025)
- The original driver was added in commit `ed264e8a7d18c` (December
2022), first appearing in v6.2
- The commit adds a single DMI entry using `oxp_x1` driver_data,
identical in pattern to 7 other X1 variant entries
- The commit is reviewed by `Ilpo Järvinen` (Intel platform maintainer)
- The patch only touches one file, adding 7 lines (a DMI table entry)
- The driver file has been moved since stable branch points, so
backporting would require path adjustment
### Conclusion
This is a straightforward device ID / hardware quirk addition that
enables an existing driver on new hardware. It meets all stable
criteria:
- Obviously correct (identical pattern to sibling entries)
- Fixes a real issue (device not recognized without entry)
- Small and contained (7 lines, 1 file)
- No new features (reuses existing `oxp_x1` code path)
- Zero risk (DMI exact match only affects specific hardware)
The only consideration is that backporting will need a path adjustment
since the file was moved, and the `oxp_x1` board type must already exist
in the target stable tree. But the pattern is clearly appropriate for
stable.
**YES**
drivers/platform/x86/oxpec.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
index 158c545d4efbb..6d4a53a2ed603 100644
--- a/drivers/platform/x86/oxpec.c
+++ b/drivers/platform/x86/oxpec.c
@@ -247,6 +247,13 @@ static const struct dmi_system_id dmi_table[] = {
},
.driver_data = (void *)oxp_x1,
},
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X1Air"),
+ },
+ .driver_data = (void *)oxp_x1,
+ },
{
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
--
2.51.0