Re: [PATCH v1 1/1] pinctrl: pinconf-generic: Use only fwnode API in parse_dt_cfg()

[Linus Walleij]

On Thu, Mar 5, 2026 at 10:50 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> The parse_dt_cfg() uses OF and fwnode APIs. Fix this inconsistency by
> fully switching it to use fwnode API and rename the function accordingly.
>
> While at it, add missing linux/property.h inclusion.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Patch applied, because obviously the kernel looks better after
this patch than before it.

I had to rebase the last hunk of changes manually.

I think there is something more to do, but you probably
already have a plan:

> -       ret = parse_dt_cfg(np, dt_params, ARRAY_SIZE(dt_params), cfg, &ncfg);
> +       ret = parse_fw_cfg(fwnode, dt_params, ARRAY_SIZE(dt_params), cfg, &ncfg);

and that uses:

#ifdef CONFIG_OF
static const struct pinconf_generic_params dt_params[] = {
    { "bias-bus-hold", PIN_CONFIG_BIAS_BUS_HOLD, 0 },
    { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 },

Are you already working on a patch? ;)

Yours,
Linus Walleij