Re: [PATCH] dt-bindings: gpio: convert Cavium ThunderX GPIO binding to YAML

[Krzysztof Kozlowski]

On Mon, Mar 09, 2026 at 01:52:52PM +0530, Shi Hao wrote:
> Convert Cavium ThunderX GPIO text based device tree
> node to YAML schema format, ensuring validation and
> consistency across Device Tree.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Is this part of some LFX/GSoC program and thus should be first reviewed
by your mentors?

> 
> Signed-off-by: Shi Hao <i.shihao.999@xxxxxxxxx>
> ---
>  .../gpio/cavium-thunder-8890-gpio.yaml        | 52 +++++++++++++++++++
>  .../bindings/gpio/gpio-thunderx.txt           | 27 ----------
>  2 files changed, 52 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml

Filename based on compatible,

>  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-thunderx.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
> new file mode 100644
> index 000000000000..16d7c347f913
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/cavium-thunder-8890-gpio.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/cavium-thunder-8890-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cavium ThunderX GPIO controller
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Device Tree binding for the GPIO controller found in

s/Device Tree binding for// because we do not need description of DT
binding that it is a DT binding.

> +  Cavium ThunderX and OCTEON-TX SoCs.
> +
> +maintainers:
> +  - Linus Walleij <linusw@xxxxxxxxxx>
> +  - Rob Herring <robh@xxxxxxxxxx>

You cannot have here subsystem maintainers. This needs platform or
driver maintainers.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - cavium,thunder-8890-gpio
> +
> +  reg:
> +    maxItems: 1
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'

Use consistent quotes, either ' or "

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    gpio_6_0: gpio@6,0 {
> +      compatible = "cavium,thunder-8890-gpio";
> +      reg = <0x3000 0x100>; /*  DEVFN = 0x30 (6:0) */

I have doubts this was checked with W=1.

Best regards,
Krzysztof