Re: [PATCH v2 1/2] media: dt-bindings: ovti,ov8856: Allow orientation & rotation props

[Krzysztof Kozlowski]

On Tue, Mar 10, 2026 at 04:21:31AM +0000, Alexander Koskovich wrote:
> Allow the orientation and rotation properties from video-interface-devices
> to be specified. The sensor can be front or rear facing and can be mounted
> at any rotation.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@xxxxx>
> ---
>  Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> index fa71f24823f2..24d4161a293b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> @@ -18,6 +18,9 @@ description: |-
>    through I2C and two-wire SCCB. The sensor output is available via CSI-2
>    serial data output (up to 4-lane).
>  
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
>  properties:
>    compatible:
>      const: ovti,ov8856
> @@ -57,6 +60,10 @@ properties:
>        This corresponds to the hardware pin XSHUTDOWN which is physically
>        active low.

I was fine with previous patch if my assumptions stated there were correct.

>  
> +  orientation: true
> +

if there is going to be new version, then drop blank line here.

> +  rotation: true
> +

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof