Re: [PATCH v2 13/14] pinctrl: realtek: Add rtd1625 pinctrl driver

[Linus Walleij]

Hi Yu-Chun,

On Fri, Mar 6, 2026 at 8:53 AM Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx> wrote:

> From: Tzuyi Chang <tychang@xxxxxxxxxxx>
>
> Add support for Realtek RTD1625 SoC using the realtek common pinctrl driver.
>
> This patch introduces the RTK_PIN_CONFIG_V2 and RTK_PIN_CONFIG_I2C macros,
> which are required to describe the specific register layout and electrical
> features (such as slew rate and high VIL) of the RTD1625 pins.
>
> Signed-off-by: Tzuyi Chang <tychang@xxxxxxxxxxx>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
(...)
> +static int __init rtd1625_pinctrl_init(void)
> +{
> +       return platform_driver_register(&rtd1625_pinctrl_driver);
> +}
> +arch_initcall(rtd1625_pinctrl_init);

Do you really need the driver to be initialized at arch_initcall()
level? Can't it just be an ordinary module?

Yours,
Linus Walleij