Re: [PATCH 7/9] ktest: Add PRE_KTEST_DIE for PRE_KTEST failures
From: Ricardo B. Marlière
Date: Tue Mar 10 2026 - 06:26:33 EST
On Mon Mar 9, 2026 at 12:00 PM -03, Steven Rostedt wrote:
> On Sat, 07 Mar 2026 19:08:02 -0300
> Ricardo B. Marlière <rbm@xxxxxxxx> wrote:
>
>> PRE_KTEST runs before the first test, but its return status is currently
>> ignored. A failing setup hook can leave the rest of the run executing in a
>> partially initialized environment.
>>
>> Add PRE_KTEST_DIE so PRE_KTEST can fail the run in the same way
>> PRE_BUILD_DIE and PRE_TEST_DIE already can. Keep the default behavior
>> unchanged when the new option is not set.
>
> Thank you for keeping the previous behavior. My PRE_KTEST usually apply
> patches that don't always apply, and yes, I depend on it "not dying" on
> failure. Which is probably why that was the way it worked, as the reason I
> created that option was to apply patches before testing.
I figured this behavior had to be there for a reason :)
Thanks for reviewing/testing btw !
>
> -- Steve