Re: [PATCH v2] mfd: core: Preserve OF node when ACPI handle is present

From: Andy Shevchenko

Date: Tue Mar 10 2026 - 06:29:11 EST


On Tue, Mar 10, 2026 at 09:21:48AM +0000, Lee Jones wrote:
> On Fri, 06 Mar 2026, Andy Shevchenko wrote:
> > On Fri, Mar 06, 2026 at 01:38:06PM +0000, Lee Jones wrote:
> > > On Thu, 26 Feb 2026, Brian Mak wrote:

...

> > > > + /*
> > > > + * FIXME: The fwnode design doesn't allow proper stacking/sharing. This
> > >
> > > So when will this be fixed exactly?
> >
> > I don't know, it's a huge task that requires of redesigning how struct
> > fwnode_handle looks like and how it cohabits with struct device. Do you
> > you think that NOTE will be more appropriate, because it may span several
> > releases.
>
> If someone is going to do the work sometime in the near future, it can
> stay as FIXME. A few releases isn't going to offend anyone. However,
> if we're just going to sit on it and this is likely to be here for an
> elongated period, it should be changed.

Then better to be just a NOTE:.

> Any idea who is planning on working on it?

I am not sure anyone is planning on working on this in the near future.
We see the problem, but it hasn't hit someone's work too much to become
a showstopper (some workarounds, or not fully correct, but acceptable
behaviour was a way out so far).

--
With Best Regards,
Andy Shevchenko