Re: [PATCH v2 10/12] clk: qcom: smd-rpm: drop determine_rate op and use CLK_ROUNDING_NOOP flag
From: Brian Masney
Date: Tue Mar 10 2026 - 06:36:34 EST
On Tue, Mar 10, 2026 at 6:17 AM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
> On 3/9/26 3:38 PM, Brian Masney wrote:
> > This clk driver has a noop determine_rate clk op. Drop this empty
> > function, and enable the CLK_ROUNDING_NOOP flag.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
> > ---
> > To: Bjorn Andersson <andersson@xxxxxxxxxx>
> > To: Michael Turquette <mturquette@xxxxxxxxxxxx>
> > To: Stephen Boyd <sboyd@xxxxxxxxxx>
> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> > Cc: linux-clk@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> > drivers/clk/qcom/clk-smd-rpm.c | 15 ++-------------
> > 1 file changed, 2 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> > index 103db984a40b950bd33fba668a292be46af6326e..8c6fc5adf5f50537a4f8d43872bf2f9065e5d6d4 100644
> > --- a/drivers/clk/qcom/clk-smd-rpm.c
> > +++ b/drivers/clk/qcom/clk-smd-rpm.c
> > @@ -35,6 +35,7 @@
> > .name = "xo_board", \
> > }, \
> > .num_parents = 1, \
> > + .flags = CLK_ROUNDING_NOOP, \
> > }, \
> > }; \
> > static struct clk_smd_rpm clk_smd_rpm_##_prefix##_active = { \
> > @@ -52,7 +53,7 @@
> > .name = "xo_board", \
> > }, \
> > .num_parents = 1, \
> > - .flags = (ao_flags), \
> > + .flags = (CLK_ROUNDING_NOOP | (ao_flags)), \
> > }, \
>
> The other two definitions (using clk_smd_rpm_branch_ops) also need this
Are you sure? clk_smd_rpm_branch_ops doesn't have a set_rate() op, and
it's been like this for years. If I add NOOP flag to this ops
structure, then clk_core_can_round() will return true with this
series, and it'll change the behavior of this driver.
Brian
Brian