Re: [PATCH v6 18/34] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure
From: Alexandre Courbot
Date: Tue Mar 10 2026 - 06:58:57 EST
On Tue Mar 10, 2026 at 11:11 AM JST, John Hubbard wrote:
<snip>
> +/// FSP writes this value to indicate successful boot completion.
> +#[expect(unused)]
> +pub(crate) const FSP_BOOT_COMPLETE_SUCCESS: u32 = 0xff;
> +
> +// Helper function to read FSP boot completion status from the correct register
> +#[expect(unused)]
> +pub(crate) fn read_fsp_boot_complete_status(
> + bar: &crate::driver::Bar0,
> + arch: Architecture,
> +) -> Result<u32> {
> + let addr = fsp_thermal_scratch_reg_addr(arch)?;
> + Ok(bar.read32(addr))
> +}
This function is unused, and modified in patch 22 - so let's just move
its definition to patch 22.