Re: [PATCH 3/3] arm64: dts: qcom: sm8250-asus-obiwan: Add ASUS ROG Phone 3

[Konrad Dybcio]

On 3/8/26 9:40 PM, Alexander Koskovich wrote:
> Supported functionality as of this initial submission:
> * Armor Case & Dock Hall Sensors
> * Camera flash/torch LED
> * Display (Tianma TA066VVHM03)
> * DisplayPort Alt Mode
> * Macro Camera (OV8856)
> * GPU (Adreno 650)
> * NFC (NXP PN553)
> * Power Button, Volume Keys
> * Regulators
> * Remoteprocs (ADSP, CDSP, SLPI)
> * UFS
> * USB
> * Video Codec (Venus)
> * Wi-Fi / Bluetooth (QCA6390)
> 
> Signed-off-by: Alexander Koskovich <akoskovich@xxxxx>
> ---

[...]

> +&cci1_i2c0 {
> +	camera@36 {
> +		compatible = "ovti,ov8856";
> +		reg = <0x36>;
> +
> +		rotation = <90>;
> +		orientation = <1>;
> +
> +		reset-gpios = <&tlmm 109 GPIO_ACTIVE_LOW>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cam_ov8856_default>;

property-n
property-names

in this order, file-wide, please

[...]

> +&cpu7_opp_table {
> +	cpu7_opp21: opp-3091200000 {
> +		opp-hz = /bits/ 64 <3091200000>;
> +		opp-peak-kBps = <8368000 51609600>;
> +	};
> +};

This, as we've established on some other thread, is fine to put in
8250.dtsi

[...]

> +				port@0 {
> +					reg = <0>;
> +					rt1715_con_hs: endpoint {

\n above, please, to separate the subnode from properties

[...]

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pm8008_default>;

ditto

[...]

> +			port@0 {
> +				reg = <0>;
> +				pm8150b_hs: endpoint {

ditto

[...]

> +&uart12 {
> +	/*
> +	 * Debug UART routed through a mux with an enable line on
> +	 * GPIO 170. The active state is unknown, so data may not
> +	 * pass through.

Hm? Is that software-triggered, or is there some sort of a debug connector?

Konrad