RE: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Peng Fan (OSS)]

Hi Mark,

Thanks for quick replying.

> Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type
> 
> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > Kernel warning on i.MX8MP-EVK when doing module test:
> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
> >
> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any
> > unmasked interrupt bit status is changed and it is released high once
> > application processor read INT1 register.
> >
> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not
> > IRQF_TRIGGER_FALLING.
> 
> There appear to be a bunch of DTS files which specify edge triggered
> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
> imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
> for this patch but probably wants cleaning up.

Yeah. This is just to clean the log that would confuse our customers,
not cause real issues on hardware.

BTW, I am also thinking whether we need to drop setting
IRQF_TIRRGER_[X] when calling request irq in this driver.

If you prefer below, I could do a V2.
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 45d7dc44c2cd0..d34a240b71922 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -1377,7 +1377,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
        if (pca9450->irq) {
                ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
                                                pca9450_irq_handler,
-                                               (IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+                                               IRQF_ONESHOT,
                                                "pca9450-irq", pca9450);

Thanks
Peng.