Re: [PATCH 57/61] reset: Prefer IS_ERR_OR_NULL over manual NULL check

Next message: Svyatoslav Ryhel: "Re: [PATCH v1 0/1] dt-bindings: display: bridge: ssd2825: inherit dsi-controller properties"
Previous message: Miguel Ojeda: "Re: [PATCH 1/2] rust: sizes: add u64 variants of SZ_* constants"
In reply to: Philipp Hahn: "[PATCH 57/61] reset: Prefer IS_ERR_OR_NULL over manual NULL check"
Next in thread: Google: "Re: [PATCH 57/61] reset: Prefer IS_ERR_OR_NULL over manual NULL check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Philipp Zabel

Date: Tue Mar 10 2026 - 10:37:49 EST

Hi Philipp,

On Di, 2026-03-10 at 12:49 +0100, Philipp Hahn wrote:
> Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
> check.
>
> Semantich change: Previously the code only printed the warning on error,
> but not when the pointer was NULL. Now the warning is printed in both
> cases!

No, rstc == NULL is valid (for optional reset controls) and must not
throw a warning.

regards
Philipp