Re: [PATCH v8 05/10] rust: io: add IoLoc type and generic I/O accessors
From: Danilo Krummrich
Date: Tue Mar 10 2026 - 11:16:06 EST
On Mon Mar 9, 2026 at 4:14 PM CET, Alexandre Courbot wrote:
> + /// Generic fallible update with runtime bounds check.
> + ///
> + /// Caution: this does not perform any synchronization. Race conditions can occur in case of
> + /// concurrent access.
NIT: I don't think this really comes as a surprise, so I'd make it "Note:"
instead.
I'd also replace "Race conditions can occur in case of concurrent access." with
something along the lines of "The caller is responsible to ensure exclusive
access if required."
> + #[inline(always)]
> + fn try_update<T, L, F>(&self, location: L, f: F) -> Result