Re: [PATCH RFC 4/7] mtd: spinand: toshiba: Add RX sampling delay values
From: Frieder Schrempf
Date: Tue Mar 10 2026 - 11:37:41 EST
On 09.03.26 16:12, Miquel Raynal wrote:
>
>> @@ -277,7 +291,7 @@ static const struct spinand_info toshiba_spinand_table[] = {
>> &update_cache_variants),
>> 0,
>> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout,
>> - tx58cxgxsxraix_ecc_get_status)),
>> + tx58cxgxsxraix_ecc_get_status),
>> /* 1.8V 4Gb (1st generation) */
>> SPINAND_INFO("TH58NYG2S3HBAI4",
>> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xAC),
>> @@ -288,7 +302,7 @@ static const struct spinand_info toshiba_spinand_table[] = {
>> &update_cache_x4_variants),
>> SPINAND_HAS_QE_BIT,
>> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout,
>> - tx58cxgxsxraix_ecc_get_status)),
>> + tx58cxgxsxraix_ecc_get_status),
>> /* 1.8V 8Gb (1st generation) */
>> SPINAND_INFO("TH58NYG3S0HBAI6",
>> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xA3),
>> @@ -299,7 +313,7 @@ static const struct spinand_info toshiba_spinand_table[] = {
>> &update_cache_x4_variants),
>> SPINAND_HAS_QE_BIT,
>> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout,
>> - tx58cxgxsxraix_ecc_get_status)),
>> + tx58cxgxsxraix_ecc_get_status),
>> };
>
> Are these 3 changes legitimate?
No, they are not. This is a last-minute fixup gone wrong.