Re: [PATCH net v4 3/5] selftests: net: rename pmtu.sh to pmtu-test.sh
From: Stefano Brivio
Date: Tue Mar 10 2026 - 12:45:41 EST
Nit, only in case this needs a re-spin for whatever reason:
On Mon, 9 Mar 2026 15:20:11 +0000
Aleksei Oladko <aleksey.oladko@xxxxxxxxxxxxx> wrote:
> Rename the pmtu.sh test script to pmtu-test.sh. No functional
> changes are made, only the file name is updated.
I don't think pmtu-test.sh is very descriptive. I think leaving it as
pmtu.sh and having the new pmtu.sh named pmtu_run.sh would be more
self-explanatory. But it's not a strong preference either way.
> Signed-off-by: Aleksei Oladko <aleksey.oladko@xxxxxxxxxxxxx>
> ---
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tools/testing/selftests/net/{pmtu.sh => pmtu-test.sh} (100%)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 605c54c0e8a3..8fa6ef771757 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -63,7 +63,7 @@ TEST_PROGS := \
> netns-name.sh \
> netns-sysctl.sh \
> nl_netdev.py \
> - pmtu.sh \
> + pmtu-test.sh \
> psock_snd.sh \
> reuseaddr_ports_exhausted.sh \
> reuseport_addr_any.sh \
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu-test.sh
> similarity index 100%
> rename from tools/testing/selftests/net/pmtu.sh
> rename to tools/testing/selftests/net/pmtu-test.sh
--
Stefano