Re: [PATCH v6 03/34] gpu: nova-core: Hopper/Blackwell: basic GPU identification

[John Hubbard]

On 3/10/26 1:06 AM, Alexandre Courbot wrote:
> On Tue Mar 10, 2026 at 11:10 AM JST, John Hubbard wrote:
...>> +                        Architecture::Blackwell => {
>> +                            // Distinguish between GB10x and GB20x series
>> +                            match chipset {
>> +                                // GB10x series: GB100, GB102
>> +                                Chipset::GB100 | Chipset::GB102 => ".fwsignature_gb10x",
>> +                                // GB20x series: GB202, GB203, GB205, GB206, GB207
>> +                                Chipset::GB202
>> +                                | Chipset::GB203
>> +                                | Chipset::GB205
>> +                                | Chipset::GB206
>> +                                | Chipset::GB207 => ".fwsignature_gb20x",
>> +                                // It's not possible to get here with a non-Blackwell chipset, but
>> +                                // Rust doesn't know that.
>> +                                _ => return Err(ENOTSUPP),
>> +                            }
>> +                        }
> 
> Can we use the same trick as Turing above to avoid the double-match and
> unused catch-all statement? That would look something like:
> 
>     Architecture::Blackwell if matches!(chipset, Chipset::GB100 | Chipset::GB102) => {
>         Some(".fwsignature_gb10x")
>     }
>     Architecture::Blackwell => Some(".fwsignature_gb20x"),
> 
> Note that this is not perfect either, but it is at least more succint.

Good catch, I was still in a Chipset mode when I wrote that, despite
having the Architecture approach everywhere. Fixed in the upcoming
v7 series.

thanks,
-- 
John Hubbard