Re: [PATCH] spi: atcspi200: Use helper function devm_clk_get_enabled()

[Mark Brown]

On Tue, Mar 10, 2026 at 04:53:02PM +0800, Pei Xiao wrote:

> -	ret = atcspi_setup(spi);
> -	if (ret)
> -		goto disable_clk;
> +	atcspi_setup(spi);

Previously we checked the return code here, now we ignore it?

>  	ret = devm_spi_register_controller(&pdev->dev, host);
> -	if (ret) {
> +	if (ret)
>  		dev_err_probe(spi->dev, ret,
>  			      "Failed to register SPI controller\n");
> -		goto disable_clk;
> -	}

Similarly (and more seriously) here?

Attachment: signature.asc
Description: PGP signature