Re: [PATCH v2 1/2] rust: support overriding crate_name
From: Miguel Ojeda
Date: Tue Mar 10 2026 - 15:58:59 EST
On Tue, Mar 10, 2026 at 8:39 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> The change to `generate_rust_analyzer.py` is safe to land even without
> the other changes in this series, so it should be possible to take
> that through rust-analyzer-next this cycle and then take the other
> changes in this series after my PR. Do I understand correctly?
Yeah, I think we could do that, but that means justifying the
rust-analyzer change on its own, which currently wouldn't be needed.
Sometimes we do things "for the future" to simplify landing them, but
do we need that here?
Either way, what I would suggest is that the changes take into account
your changes, i.e. to base the patch on top of what you have in the
branch, so that we can review it and so that you are happy with it one
way or the other.
Cheers,
Miguel