RE: [PATCHv3 net-next] net: xgbe: use device_get_mac_addr

[Sai Krishna Gajula]

> -----Original Message-----
> From: Rosen Penev <rosenp@xxxxxxxxx>
> Sent: Wednesday, March 11, 2026 1:17 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Raju Rangoju <Raju.Rangoju@xxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: [PATCHv3 net-next] net: xgbe: use device_get_mac_addr
> 
> device_get_mac_addr is basically device_property_read_u8_array with an
> is_valid_ether_addr call. Allows just checking for ret. Remove
> XGBE_MAC_ADDR_PROPERTY. device_get_mac_addr supports more
> properties than just "mac-address". Signed-off-by:
> 
> device_get_mac_addr is basically device_property_read_u8_array with an
> is_valid_ether_addr call. Allows just checking for ret.
> 
> Remove XGBE_MAC_ADDR_PROPERTY. device_get_mac_addr supports more
> properties than just "mac-address".
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  v3: remove unreachaable !ret condition. device_get_mac_address sets it  to
> that.
>  v2: remove XGBE_MAC_ADDR_PROPERTY
>  drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 10 +++-------
>  drivers/net/ethernet/amd/xgbe/xgbe.h          |  1 -
>  2 files changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> index 47d53e59ccf6..0debe015073e 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c
> @@ -252,13 +252,9 @@ static int xgbe_platform_probe(struct
> platform_device *pdev)
>  		dev_dbg(dev, "sir1_regs  = %p\n", pdata->sir1_regs);
> 
>  	/* Retrieve the MAC address */
> -	ret = device_property_read_u8_array(dev,
> XGBE_MAC_ADDR_PROPERTY,
> -					    pdata->mac_addr,
> -					    sizeof(pdata->mac_addr));
> -	if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
> -		dev_err(dev, "invalid %s property\n",
> XGBE_MAC_ADDR_PROPERTY);
> -		if (!ret)
> -			ret = -EINVAL;
> +	ret = device_get_mac_address(dev, pdata->mac_addr);
> +	if (ret) {
> +		dev_err(dev, "invalid MAC address property\n");
>  		goto err_io;
>  	}
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h
> b/drivers/net/ethernet/amd/xgbe/xgbe.h
> index 4333d269ee84..e57e416a1d5a 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe.h
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h
> @@ -96,7 +96,6 @@
>  	min_t(unsigned int, IEEE_8021QAZ_MAX_TCS, (_cnt))
> 
>  /* Common property names */
> -#define XGBE_MAC_ADDR_PROPERTY	"mac-address"
>  #define XGBE_PHY_MODE_PROPERTY	"phy-mode"
>  #define XGBE_DMA_IRQS_PROPERTY	"amd,per-channel-interrupt"
>  #define XGBE_SPEEDSET_PROPERTY	"amd,speed-set"
> --
> 2.53.0
> 
Reviewed-by: Sai Krishna <saikrishnag@xxxxxxxxxxx>