Re: [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt

From: Krzysztof Kozlowski

Date: Tue Mar 10 2026 - 16:19:13 EST


On 10/03/2026 18:48, Taha Ed-Dafili wrote:
> The AD5504 full-scale range is hardware-determined by the
> R_SEL pin (0-30V or 0-60V). Previously, the driver incorrectly used the
> VCC regulator voltage to calculate the scale.
>
> Update the probe function to read the standard "output-range-microvolt"
> property as a two-element array to determine the correct full-scale range.
> Use the MILLI macro for clearer millivolt assignments and simplify the
> probe logic using a local device pointer.
>
> Suggested-by: David Lechner <dlechner@xxxxxxxxxxxx>
> Suggested-by: Andy Shevchenko <andy@xxxxxxxxxx>

Where were these suggestions given?

Best regards,
Krzysztof