[PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions
From: tomasz . unger
Date: Tue Mar 10 2026 - 18:14:12 EST
From: Tomasz Unger <tomasz.unger@xxxxxxxx>
Signed-off-by: Tomasz Unger <tomasz.unger@xxxxxxxx>
---
Changes in v3:
- Extended cleanup to all 27 files in the driver containing redundant
'return;' statements at the end of void functions (as suggested by
Andy Shevchenko): inputfifo.c, bufq.c, ifmtr.c, frame.c, rx.c,
binary.c, ia_css_debug.c, mmu_public.h,
isp2400_input_system_private.h, hmm_bo.c, sh_css.c, sp_private.h,
fifo_monitor_private.h, isp.c, input_formatter_private.h, irq.c,
mmu.c, fifo_monitor.c, gp_device.c, gdc.c, event_fifo_private.h,
isp_private.h, input_formatter.c, irq_private.h, gpio_private.h,
gp_device_private.h, atomisp_cmd.c
- Each removed 'return;' was verified to be at the end of a void function
- Compiled successfully: make M=drivers/staging/media/atomisp/
- Module loaded successfully in QEMU with Linux 7.0-rc3
- Link to v2: https://lore.kernel.org/r/20260310-atomisp-remove-void-return-v2b-v2-1-b0e73f498e25@xxxxxxxx
Changes in v2:
- Fixed subject prefix to 'media: staging: atomisp:' (reported by media CI robot)
- Rebased on media-committers/next
- Verified with checkpatch.pl --strict: 0 errors, 0 warnings
- Compiled successfully: make M=drivers/staging/media/atomisp/
- Module loaded successfully in QEMU with Linux 7.0-rc2
- Link to v1: https://lore.kernel.org/r/20260305-atomisp-remove-void-return-v2b-v1-1-902e534ecb48@xxxxxxxx
---
Tomasz Unger (28):
media: staging: atomisp: Remove unnecessary return statement in void function
media: staging: atomisp: Remove unnecessary return statements in inputfifo.c
media: staging: atomisp: Remove unnecessary return statement in bufq.c
media: staging: atomisp: Remove unnecessary return statement in ifmtr.c
media: staging: atomisp: Remove unnecessary return statements in frame.c
media: staging: atomisp: Remove unnecessary return statements in rx.c
media: staging: atomisp: Remove unnecessary return statement in binary.c
media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c
media: staging: atomisp: Remove unnecessary return statement in mmu_public.h
media: staging: atomisp: Remove unnecessary return statements in isp2400_input_system_private.h
media: staging: atomisp: Remove unnecessary return statements in hmm_bo.c
media: staging: atomisp: Remove unnecessary return statements in sh_css.c
media: staging: atomisp: Remove unnecessary return statements in sp_private.h
media: staging: atomisp: Remove unnecessary return statements in fifo_monitor_private.h
media: staging: atomisp: Remove unnecessary return statement in isp.c
media: staging: atomisp: Remove unnecessary return statement in input_formatter_private.h
media: staging: atomisp: Remove unnecessary return statements in irq.c
media: staging: atomisp: Remove unnecessary return statements in mmu.c
media: staging: atomisp: Remove unnecessary return statements in fifo_monitor.c
media: staging: atomisp: Remove unnecessary return statement in gp_device.c
media: staging: atomisp: Remove unnecessary return statements in gdc.c
media: staging: atomisp: Remove unnecessary return statement in event_fifo_private.h
media: staging: atomisp: Remove unnecessary return statements in isp_private.h
media: staging: atomisp: Remove unnecessary return statements in input_formatter.c
media: staging: atomisp: Remove unnecessary return statement in irq_private.h
media: staging: atomisp: Remove unnecessary return statement in gpio_private.h
media: staging: atomisp: Remove unnecessary return statement in gp_device_private.h
media: staging: atomisp: Remove unnecessary return statement in atomisp_cmd.c
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
.../pci/hive_isp_css_common/host/event_fifo_private.h | 1 -
.../atomisp/pci/hive_isp_css_common/host/fifo_monitor.c | 3 ---
.../pci/hive_isp_css_common/host/fifo_monitor_private.h | 2 --
.../media/atomisp/pci/hive_isp_css_common/host/gdc.c | 2 --
.../atomisp/pci/hive_isp_css_common/host/gp_device.c | 1 -
.../pci/hive_isp_css_common/host/gp_device_private.h | 1 -
.../atomisp/pci/hive_isp_css_common/host/gpio_private.h | 1 -
.../pci/hive_isp_css_common/host/input_formatter.c | 5 -----
.../hive_isp_css_common/host/input_formatter_private.h | 1 -
.../media/atomisp/pci/hive_isp_css_common/host/irq.c | 8 --------
.../atomisp/pci/hive_isp_css_common/host/irq_private.h | 1 -
.../media/atomisp/pci/hive_isp_css_common/host/isp.c | 1 -
.../atomisp/pci/hive_isp_css_common/host/isp_private.h | 6 ------
.../media/atomisp/pci/hive_isp_css_common/host/mmu.c | 2 --
.../atomisp/pci/hive_isp_css_common/host/sp_private.h | 8 --------
.../atomisp/pci/hive_isp_css_include/host/mmu_public.h | 1 -
drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 4 ----
.../media/atomisp/pci/isp2400_input_system_private.h | 4 ----
.../media/atomisp/pci/runtime/binary/src/binary.c | 1 -
.../staging/media/atomisp/pci/runtime/bufq/src/bufq.c | 1 -
.../media/atomisp/pci/runtime/debug/src/ia_css_debug.c | 8 --------
.../staging/media/atomisp/pci/runtime/frame/src/frame.c | 4 ----
.../staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 -
.../media/atomisp/pci/runtime/inputfifo/src/inputfifo.c | 16 ----------------
drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 4 ----
drivers/staging/media/atomisp/pci/sh_css.c | 2 --
drivers/staging/media/atomisp/pci/sh_css_param_dvs.c | 1 -
28 files changed, 91 deletions(-)
---
base-commit: c24bad1b9ac3ee3a63dcdeaa082cf671a4be1345
change-id: 20260305-atomisp-remove-void-return-v2b-4ce912de212c
Best regards,
--
Tomasz Unger <tomasz.unger@xxxxxxxx>