Re: [PATCH v2 08/11] media: qcom: iris: merge hfi_response_ops and hfi_command_ops
From: Dmitry Baryshkov
Date: Tue Mar 10 2026 - 20:23:57 EST
On Fri, Mar 06, 2026 at 02:17:12PM +0530, Dikshita Agarwal wrote:
>
>
> On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote:
> > There is little point in having two different structures for HFI-related
> > core ops. Merge both of them into the new iris_hfi_ops structure.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/media/platform/qcom/iris/iris_core.h | 2 +-
> > drivers/media/platform/qcom/iris/iris_hfi_common.c | 6 +++---
> > drivers/media/platform/qcom/iris/iris_hfi_common.h | 8 +++-----
> > drivers/media/platform/qcom/iris/iris_hfi_gen1.h | 4 ++--
> > drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 8 +++++---
> > drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c | 11 +----------
> > drivers/media/platform/qcom/iris/iris_hfi_gen2.h | 4 ++--
> > drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 8 +++++---
> > drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c | 11 +----------
> > drivers/media/platform/qcom/iris/iris_platform_common.h | 3 +--
> > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 6 ++----
> > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 12 ++++--------
> > drivers/media/platform/qcom/iris/iris_probe.c | 3 +--
> > 13 files changed, 31 insertions(+), 55 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h
> > index d10a03aa5685..d919c7c16106 100644
> > --- a/drivers/media/platform/qcom/iris/iris_core.h
> > +++ b/drivers/media/platform/qcom/iris/iris_core.h
> > @@ -112,7 +112,7 @@ struct iris_core {
> > u32 header_id;
> > u32 packet_id;
> > struct iris_core_power power;
> > - const struct iris_hfi_command_ops *hfi_ops;
> > + const struct iris_hfi_ops *hfi_ops;
> > const struct iris_hfi_response_ops *hfi_response_ops;
>
> isn't this creating compilation issue? This is being removed in this patch.
No, compiler ignores unknown struct pointers until one wants to peek
into it. But I should drop it anyway.
--
With best wishes
Dmitry