Re: [PATCH 1/7] KVM: SVM: Initialize FRED VMCB fields

[Shivansh Dhiman]

On 10-03-2026 00:27, Sean Christopherson wrote:
>>>> +	save->fred_rsp0 = 0;
>>>> +	save->fred_rsp1 = 0;
>>>> +	save->fred_rsp2 = 0;
>>>> +	save->fred_rsp3 = 0;
>>>> +	save->fred_stklvls = 0;
>>>> +	save->fred_ssp1 = 0;
>>>> +	save->fred_ssp2 = 0;
>>>> +	save->fred_ssp3 = 0;
>>>> +	save->fred_config = 0;
>>>
>>> Is this architecturally correct?  I.e. are all the FRED MSRs zeroed on INIT?
>>
>> Yes that's right, the FRED MSRs are zeroed on init.
> 
> Please use that as the basis for the changelog.  "Ensure that a vCPU starts with
> a clean and valid FRED state on capable hardware" is largely meaningless because
> vCPU structures are zero-allocated.

Will do. Thanks for pointing out.

- Shivansh