Re: [PATCH v11 2/2] PCI: eic7700: Add Eswin PCIe host controller driver

[Manivannan Sadhasivam]

On Thu, Mar 05, 2026 at 04:01:20PM +0800, Min Lin wrote:
> Hi Mani,
> 
> Thanks for your kind suggestion and help.
> 
> 
> > -----Original Messages-----
> > From: "Manivannan Sadhasivam" <mani@xxxxxxxxxx>
> > Send time:Thursday, 05/03/2026 14:07:31
> > To: zhangsenchuan@xxxxxxxxxxxxxxxxxx
> > Cc: bhelgaas@xxxxxxxxxx, krzk+dt@xxxxxxxxxx, conor+dt@xxxxxxxxxx, lpieralisi@xxxxxxxxxx, kwilczynski@xxxxxxxxxx, robh@xxxxxxxxxx, p.zabel@xxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, christian.bruel@xxxxxxxxxxx, shradha.t@xxxxxxxxxxx, krishna.chundru@xxxxxxxxxxxxxxxx, thippeswamy.havalige@xxxxxxx, inochiama@xxxxxxxxx, Frank.li@xxxxxxx, ningyu@xxxxxxxxxxxxxxxxxx, linmin@xxxxxxxxxxxxxxxxxx, pinkesh.vaghela@xxxxxxxxxxxxxx, ouyanghui@xxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v11 2/2] PCI: eic7700: Add Eswin PCIe host controller driver
> > 
> > On Fri, Feb 27, 2026 at 07:18:08PM +0800, zhangsenchuan@xxxxxxxxxxxxxxxxxx wrote:
> > > From: Senchuan Zhang <zhangsenchuan@xxxxxxxxxxxxxxxxxx>
> > > 
> > > Add driver for the Eswin EIC7700 PCIe host controller, which is based on
> > > the DesignWare PCIe core, IP revision 5.96a. The PCIe Gen.3 controller
> > > supports a data rate of 8 GT/s and 4 channels, support INTx and MSI
> > > interrupts.
> > > 
> > 
> > Is the driver going to work only for the PCIe RC IP in EIC7700 SoC or for the
> > upcoming Eswin SoCs as well? Just curious because, we don't name drivers based
> > on one SoC name, but by the vendor so that the driver (if compatible) can be
> > used across other SoCs from the vendor.
> > 
> > If it can work across other SoCs, then I can change 'eic7700' to 'eswin', where
> > applicable while applying.
> > 
> 
> This PCIe RC IP in EIC7700 will only be used for EIC7700 SoC. One thing for sure
> is our next SoC will use a higher IP revision of the DesignWare PCIe core.
> In the future, there is no doubt that the use of IP from other manufacturers may
> be considered.
> 
> Based on this, may I ask which name do you think is better, eic7700' or 'eswin'?
> 

I'd suggest going with just 'eswin'. If the future revisions come up with
non-dwc based IPs, we can name them appropriately.

> I found there is a commit on drivers/pci/controller/dwc/pcie-tegra194.c
> It added Tegra234 PCIe support in pcie-tegra194.c
> Is this naming approach no longer recommended?
> 

Yes, that predates my time with host controller drivers. I strongly suggest
naming the drivers based on vendors or family to avoid creating an impression
that the driver only supports one SoC version.

Since you agreed for renaming, I took the liberty to do the change myself and
applied the patches. I also added the maintainers entry. Please take a look at
the commits and confirm if everything is OK:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dwc-eswin

- Mani

-- 
மணிவண்ணன் சதாசிவம்