Re: [PATCH v2 24/25] dt-bindings: reserved-memory: Add Google Kinfo Pixel reserved memory

[Krzysztof Kozlowski]

On Wed, Mar 11, 2026 at 01:46:08AM +0530, Mukesh Ojha wrote:
> Add documentation for Google Kinfo Pixel reserved memory area.
> 
> Co-developed-by: Eugen Hristev <eugen.hristev@xxxxxxxxxx>
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxx>
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/reserved-memory/google,kinfo.yaml     | 46 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/reserved-memory/google,kinfo.yaml b/Documentation/devicetree/bindings/reserved-memory/google,kinfo.yaml
> new file mode 100644
> index 000000000000..2f964151f0c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/google,kinfo.yaml

Nothing improved, read previous feedback.

> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/google,kinfo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google Pixel Kinfo reserved memory
> +
> +maintainers:
> +  - Eugen Hristev <eugen.hristev@xxxxxxxxxx>
> +  - Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  This binding represents reserved-memory used to store data for firmware/bootloader

Nothing improved.

> +  on the Pixel platform. The stored data is debugging information of the running
> +  kernel.
> +
> +allOf:
> +  - $ref: reserved-memory.yaml
> +
> +properties:
> +  compatible:
> +    const: google,debug-kinfo
> +
> +  reg:
> +    description: page-aligned region of memory containing debugging data of running kernel

Missing constraints.

Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).  However don't wrap blindly (see Kernel coding style).

Best regards,
Krzysztof