RE: [PATCH v3 3/4] mmc: sdhci-esdhc-imx: remove duplicate HS400 bus width validation
From: Bough Chen
Date: Wed Mar 11 2026 - 06:24:07 EST
> -----Original Message-----
> From: Luke Wang <ziniu.wang_1@xxxxxxx>
> Sent: 2026年3月11日 17:50
> To: adrian.hunter@xxxxxxxxx; ulf.hansson@xxxxxxxxxx; Bough Chen
> <haibo.chen@xxxxxxx>
> Cc: Frank Li <frank.li@xxxxxxx>; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-mmc@xxxxxxxxxxxxxxx; dl-S32 <S32@xxxxxxx>;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v3 3/4] mmc: sdhci-esdhc-imx: remove duplicate HS400 bus
> width validation
>
> From: Luke Wang <ziniu.wang_1@xxxxxxx>
>
> mmc_validate_host_caps() already validates that HS400/HS400ES requires 8-bit
> bus width. Remove the duplicate validation.
Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>
Regards
Haibo Chen
>
> Signed-off-by: Luke Wang <ziniu.wang_1@xxxxxxx>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index b607d4ffc562..d49069986efc 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1833,10 +1833,6 @@ sdhci_esdhc_imx_probe_dt(struct platform_device
> *pdev,
>
> sdhci_get_property(pdev);
>
> - /* HS400/HS400ES require 8 bit bus */
> - if (!(host->mmc->caps & MMC_CAP_8_BIT_DATA))
> - host->mmc->caps2 &= ~(MMC_CAP2_HS400 |
> MMC_CAP2_HS400_ES);
> -
> if (mmc_gpio_get_cd(host->mmc) >= 0)
> host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> --
> 2.34.1